Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: improve storage error message #8740

Merged
merged 6 commits into from
Dec 18, 2024

Conversation

LingyuCoder
Copy link
Contributor

@LingyuCoder LingyuCoder commented Dec 17, 2024

Summary

  • add fs errors and storage error to print more message
  • change fs to storage level

generated by copilot

This pull request introduces significant changes to the rspack_storage module, primarily focusing on enhancing error handling and refactoring the storage system. The key changes include the introduction of new error types, the replacement of existing result types, and the addition of new functionalities to the storage system.

Enhancements to Error Handling:

  • crates/rspack_storage/src/error.rs: Introduced new error types StorageError, StorageErrorType, and StorageErrorReason, along with the ValidateResult enum to improve error handling and diagnostics.
  • crates/rspack_storage/src/fs/error.rs: Added StorageFSError and BatchStorageFSError to handle filesystem-specific errors with detailed error messages and operations.

Refactoring and Improvements:

Addition of New Functionalities:

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Dec 17, 2024
Copy link

netlify bot commented Dec 17, 2024

Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit 4c89096
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/676245b0500dd00007267967

@LingyuCoder LingyuCoder marked this pull request as ready for review December 18, 2024 03:02
jerrykingxyz
jerrykingxyz previously approved these changes Dec 18, 2024
@LingyuCoder LingyuCoder merged commit f7ba52f into main Dec 18, 2024
32 checks passed
@LingyuCoder LingyuCoder deleted the refactor/improve-storage-error branch December 18, 2024 04:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team The issue/pr is created by the member of Rspack.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants